search

alzamer2 / Crunchyroll-XML-Decoder-py3

GNU General Public License v3.0
17 stars 5 forks source link

Code not working after update #5

Closed alzamer2 closed 3 years ago

alzamer2 commented 5 years ago

the latest update change file settings.ini structure so you need to delete the setting.ini first then run the code

darkhelmet2016 commented 5 years ago

Noticed some of the files had python 36 and some had 36 still will those eventually be updated?

darkhelmet2016 commented 5 years ago

Just checked a file with hard subs and it did not output in mkv but kept the file as ts. Show was added today. https://www.crunchyroll.com/goshogun/goshogun-the-time-etranger-goshogun-the-time-etranger-dub-784915

No error was given during output.

alzamer2 commented 5 years ago

are you sure no error showed up? and can you tell me more about what do you mean with 36?

darkhelmet2016 commented 5 years ago

The pycache folder left behind files like altfuncs.cpython-36 and also made a file named altfuncs.cpython-37 instead of getting rid of depreciated files, Not sure if this is what caused the file to not mux properly.

Crunchyroll hasn't changed anything.

If you don't have a premium account, go and sign up for one now. It's well worth it, and supports the animators.

Booting up...

Now Downloading - GoShogun - GoShogun- The Time Etranger (Dub) 810MB/810MB |%100 @ 7.18Mb/s Part#534 |%100.0

---- Downloading Subtitle ----

The video has hardcoded subtitles. Press any key to continue . . .

alzamer2 commented 5 years ago

about altfuncs.cpython-36 and altfuncs.cpython-37 these are only compliled files for python you can ignot them i forgot line for debug in code it should mux now after update even though because its ts file it will work any way, i fixed it and updated the code

darkhelmet2016 commented 5 years ago

But one question is this program not decrypting subs right? A lot of them use formatting that does not seem to carry over like the bold outline they use for subs and when they use stylized subs with colors for screen text.

alzamer2 commented 5 years ago

hmm, I don't understand what do you mean by "A lot of them use formatting that does not seem to carry over like the bold outline they use for subs and when they use stylized subs with colors for screen text." if you mean compared to other fansubs the subtitle this program rip don't have styles, then you got the wrong idea Crunchyroll even though they use ASS they use minimum styles in their subtitle:

darkhelmet2016 commented 5 years ago

Actually they do use color in subs. https://www.crunchyroll.com/the-rising-of-the-shield-hero Also you never noticed the big black border around their subs? on their apps and on their streams on the episode pages? That is formatting. Download some of the rips from HS. There is like a 2-3 in black border around their subs from when they rip CR shows. They use color subs in some shows to match what is on the screen text in Japanese what is translated. The Rising of the Shield Hero Episode 1 The Shield Hero Watch on Crunchyroll The Rising of the Shield Hero Episode 1 The Shield Hero Watch on Crunchyroll (1)

darkhelmet2016 commented 3 years ago

See you closed this without addressing the issue of the formatting and the fonts. When HS was doing shows they made sure that the fonts were also included in the files.