alzamer2 / Crunchyroll-XML-Decoder-py3

GNU General Public License v3.0
17 stars 5 forks source link

Autocatch issue #8

Open jnyfiveoh opened 5 years ago

jnyfiveoh commented 5 years ago

Weird issue I am encountering. Pardon if it is user error.

When I attempt to use the auto catch link option it continuously starts to download: The Rising of the Shield Hero Episode - 4 - Lullaby at Dawn.

This happens regardless if I try to use different links.

Current link attempted: https://www.crunchyroll.com/konosuba-gods-blessing-on-this-wonderful-world

Is there a setting somewhere that tracks last incomplete file of some sort?

alzamer2 commented 5 years ago

hi did it got fixed?

jnyfiveoh commented 5 years ago

hi did it got fixed?

Hello, It was user error. I did not realize there was a queue file. Currently looking at the app to see if there is a function to download only specific dub when using auto catch links

alzamer2 commented 5 years ago

for now no, but you can manually add the dub link to queue text so only the code download them

jnyfiveoh commented 5 years ago

for now no, but you can manually add the dub link to queue text so only the code download them

Understood, I did notice sometimes, when using queue option it will crash the app. Other times it will ask for the url twice

alzamer2 commented 5 years ago

can you send me links that crash it?

jnyfiveoh commented 5 years ago

can you send me links that crash it?

https://www.crunchyroll.com/konosuba-gods-blessing-on-this-wonderful-world

I was assuming because it was attempting to catch all the other dub links. When I edited and cleaned the queue.txt it seemed be happy

alzamer2 commented 5 years ago

ok i think i know where the problem, but for now if you reduce the number of connection to 1 it will work out until i edit the code

jnyfiveoh commented 5 years ago

Understood. Thanks for the update

darkhelmet2016 commented 5 years ago

Unless you need the English dub you can set it to filter it out in the options under Dub Filter

alzamer2 commented 5 years ago

@darkhelmet2016 the problem are the dub video has lower parts than sub, the code has problem when spliting these part, i plan in next patch to add limiter for number of connection that linked to number of parts for example dub link https://www.crunchyroll.com/konosuba-gods-blessing-on-this-wonderful-world/episode-2-an-explosion-for-this-chunibyo-780942 has only 13 part, when split to 8 connection, it will has some issue

alzamer2 commented 5 years ago

maybe i will work into it nxt 2 days

darkhelmet2016 commented 5 years ago

"Hello, It was user error. I did not realize there was a queue file. Currently looking at the app to see if there is a function to download only specific dub when using auto catch links"

@alzamer2 Was more for the dub one he asked about and was thinking more of of a temp fix if he did not need more than the Japanese version

alzamer2 commented 5 years ago

ok i did update the code and was able to download all episode of https://www.crunchyroll.com/konosuba-gods-blessing-on-this-wonderful-world (sub and dub) without problem check it out and give me feedback

darkhelmet2016 commented 5 years ago

Booting up...

Traceback (most recent call last): File "C:\Users\Public\Crunchyroll-XML-Decoder_link\crunchy-xml-decoder-py3.py" , line 407, in make_choise() File "C:\Users\Public\Crunchyroll-XML-Decoder_link\crunchy-xml-decoder-py3.py" , line 376, in make_choise queueu(os.path.join('.','queue.txt')) File "C:\Users\Public\Crunchyroll-XML-Decoder_link\crunchy-xml-decoder-py3.py" , line 127, in queueu ultimate(line.rstrip('\n'), '', '') File "crunchy-xml-decoder\ultimate.py", line 79, in ultimate media_id = re.findall(r'https?://www.crunchyroll.com/.+/.+-(\d*)',page_url )[0] IndexError: list index out of range Press any key to continue . . .

alzamer2 commented 5 years ago

hmm can you check queue file i think there is problem in it

darkhelmet2016 commented 5 years ago

Yea, think it copied the wrong url for the show and not the episode, but would still be a nice feature if you could just put in the shows url in the queue file and have it just download by the show instead of a dozen urls clogging it up.

alzamer2 commented 5 years ago

i can do it, but he point of queue file is to control which episode to download even in bulk

i plan to make it check the link is show link or episode link, if show it will auto catch it to the queue file

darkhelmet2016 commented 5 years ago

I know, but some of those shows have a hundred or more links like naruto or bleach. That is just a lot of clutter when you want to do back to back shows. Did yu-gi-oh that way for a friend and never again. :P

alzamer2 commented 5 years ago

hmm you know auto catch is function that extract link rom page then add them to queue file and run queue function, right?

Dokman commented 4 years ago

i have been bugged with usa proxy to download with autocatch and the program can't detect the links, so i don't know how to make it automatically but... that error i didn't have it.

alzamer2 commented 4 years ago

are you sure that anime page opens in us? some anime only for EU, at first I thought all anime in Crunchyroll are open to using so I used us proxy as default , but later I found some anime only to some EU contry (dont remember that anime name) so i made it to option in setting can you give me link for that anime page?

alzamer2 commented 4 years ago

here trick to check which contry that anime for get anime page link https://www.crunchyroll.com/military and add .rss https://www.crunchyroll.com/military.rss then look for if "us" there then you should be able to view

Dokman commented 4 years ago

Ok i Will tell you tomorrow and thx as always <3

alzamer2 commented 4 years ago

you are welcome

Dokman commented 4 years ago

i am in EU and i want to watch this one but the autocatch can't detect the anime https://www.crunchyroll.com/granblue-fantasy-the-animation

alzamer2 commented 4 years ago

hmm i checked and this show can be viewed in us are you sure your us setting is on? here is links by the way http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-1-girl-in-blue-733307 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-2-departure-733309 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-3-meet-the-wind-733311 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-4-a-helmsmans-resolve-733313 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-5-the-storm-guardian-733315 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-6-the-veil-is-lifted-733317 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-7-the-iron-giant-733319 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-8-a-pair-apart-733321 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-9-horizon-in-the-clouds-733323 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-10-separation-733325 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-11-lyrias-wish-733327 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-12-showdown-on-the-high-seas-733329 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-13-another-sky-733331 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-1-skyfarers-in-the-blue-789458 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-2-the-albion-citadel-789459 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-3-false-freedom-789460 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-4-unconveyable-feelings-789461 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-5-katalina-and-vira-789462

alzamer2 commented 4 years ago

hmm i checked and this show can be viewed in us are you sure your us setting is on? here is links by the way http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-1-girl-in-blue-733307 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-2-departure-733309 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-3-meet-the-wind-733311 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-4-a-helmsmans-resolve-733313 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-5-the-storm-guardian-733315 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-6-the-veil-is-lifted-733317 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-7-the-iron-giant-733319 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-8-a-pair-apart-733321 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-9-horizon-in-the-clouds-733323 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-10-separation-733325 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-11-lyrias-wish-733327 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-12-showdown-on-the-high-seas-733329 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-13-another-sky-733331 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-1-skyfarers-in-the-blue-789458 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-2-the-albion-citadel-789459 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-3-false-freedom-789460 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-4-unconveyable-feelings-789461 http://www.crunchyroll.com/granblue-fantasy-the-animation/episode-5-katalina-and-vira-789462

alzamer2 commented 4 years ago

hmm i checked and this show can be viewed in us are you sure your us setting is on? here is links by the way

Dokman commented 4 years ago

i am using this settings image

alzamer2 commented 4 years ago

hmm i want you to try 2 things first is deleting queue file, some time if there some lines in queue file that code cant read it stop running the other thing is to use links above to download at least 1 episode to make sure that code is running, and if it not , to see where the error happen

Dokman commented 4 years ago

i make it running with the links above and with a new queue file, but... when i try to make it with autocatch doesn't work 😓

alzamer2 commented 4 years ago

ok so it seem only autocatch has problem then will track it back

alzamer2 commented 4 years ago

say when you try to autocatch does not just give you black screen then end without doing any thing or there is error msg?

alzamer2 commented 4 years ago

you see its working for me so i cantt found out the problem if i dont face it or there is error msg ohh and can you paste here the link you fail autocatch with?

Dokman commented 4 years ago

okay idk what i've done it's working for me now, so i think the issue can be closed, i've tested it with a new clone and it's working very well all

alzamer2 commented 4 years ago

Maybe there was problem in 1of the files And now it gone If you get similar error try to screenshot it to track it back

On Thu, Nov 7, 2019, 9:12 AM Sergi Canaleta Fondó notifications@github.com wrote:

okay idk what i've done it's working for me now, so i think the issue can be closed, i've tested it with a new clone and it's working very well all

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alzamer2/Crunchyroll-XML-Decoder-py3/issues/8?email_source=notifications&email_token=ABCI5LUPLBNKDHPBMGJBVZLQSO5XBA5CNFSM4HNIZVU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDLMCKY#issuecomment-550945067, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCI5LS2QY55CDXZ5TEAYZTQSO5XBANCNFSM4HNIZVUQ .

vampjoseph commented 4 years ago

Sorry to hijack and necro someone else's support ticket, but I have a problem with autocatch. As in when I select it from the menu, it spits out an error message and then closes the cmd window without allowing me to input my link. I have already cleared the queue file and it didn't fix it.

Edit: Nevermind. Tried using the dos command to try and force autocatch and now it crashes as soon as the modules load. I've gone back to jaw20's version.

The error is as follows:

Traceback (most recent call last): File "F:\Crunchyroll-XML-Decoder-py3\crunchy-xml-decoder-py3.py", line 645, in menutest.start() File "crunchy-xml-decoder\pretyconsole.py", line 116, in start_ self.run_menu('Main') File "crunchy-xml-decoder\pretyconsole.py", line 143, in runmenu output = function[0](*function[1], **function_[2]) File "F:\Crunchyroll-XML-Decoder-py3\crunchy-xml-decoder-py3.py", line 536, in autocatch_t autocatch() File "crunchy-xml-decoder\altfuncs.py", line 371, in autocatch url = ''.join(re.findall(r'(https?://www.crunchyroll.com/)(?:[\w-]{2,5}/)?(.+?)(?=/|$)',url)[0])+'?skip_wall=1' File "C:\Python38\lib\re.py", line 239, in findall return _compile(pattern, flags).findall(string) TypeError: expected string or bytes-like object