am-a / journal-search

1 stars 0 forks source link

More a question than an issue #1

Closed franckflo closed 1 year ago

franckflo commented 1 year ago

Hi, I've been looking for this functionality for a while, so thanks for creating a module about it!

I'm not sure how that works. I use Foundry v10 and no module changing the Journal function. When I type a keyword in the journal search (top of the tab), the only returned items are those with the searched term in their title. Am I using this incorrectly ?

am-a commented 1 year ago

Hi @franckflo - This may have been a bug. Try updating to the latest (v0.0.6) version!

I think was was happening before is that the results are being hidden

am-a commented 1 year ago

@franckflo it should look like this: image

franckflo commented 1 year ago

Got it. That works, I actually was hoping the module was allowing to search within Journals at the tab level. Right now it only looks for terms that are in the subject line.

am-a commented 1 year ago

Hi @franckflo - The way it works is that extends the default search of Foundry by checking the contents of the page (vs Foundry only using the page titles).

So if a match within the page is found, a preview will be generated and appear under the heading of the relevant page.

If the match is only within the header of the page, there will be no preview but the page will be still be in the list (this is the default Foundry behaviour).

Can you explain what you mean by searching within journals at tab level? Do you mean all the journals available?

franckflo commented 1 year ago

What I meant is that I was looking for a module where I can perform a search on the Journal Tab on the top right of the FVTT interface. It would look for the searched term inside all the journals (not just their title).

am-a commented 1 year ago

Ah I see @franckflo - I'll add it as an enhancement. Thanks for the feedback!

franckflo commented 1 year ago

That's wonderful, thanks!

am-a commented 1 year ago

@franckflo - 0.0.7 should now include that functionality