am-impact / amnav

Navigation plugin for Craft
168 stars 20 forks source link

Referenced entries do not propagate updates. #1

Closed aowie1 closed 9 years ago

aowie1 commented 9 years ago

If I reference an entry in a nav item, then change that original entry's title, the nav item does not update.

I assume this is because static copies are stored in the table. The entryID is still stored in that same record so I'm not sure why you don't dynamically pull in those values vs. cloning.

hubertprein commented 9 years ago

In short, flexibility and performance.

We want flexibility in our menus that allow you to name a button exactly the way you want it, completely seperated from the entry's title. I've had several occassions where our customers required a different name in the menu, but still keep the entry's title for the template view.

Next is the performance. I don't fetch the entries based on their entry IDs and build the navigation dynamically through that, because that involves alot more queries and can really slow down your page load on large menus. I also use the entry ID to update the URL when you save the linked entry.

I can make an update on the menu's settings, where you have the option to enable entry update support, to also update the page's name when you save the entry, rather than force it. Will this solution work out for you?

aowie1 commented 9 years ago

Absolutely!

One other note I had though: If you delete the original entry, the nav item should also be deleted.

hubertprein commented 9 years ago

Instead of creating an option, it's been done for you automatically. Thanks for the side note where pages actually had to be deleted if linked to an Entry!

Please see the latest release: https://github.com/am-impact/amnav/releases/tag/1.1.1