am-impact / amnav

Navigation plugin for Craft
168 stars 20 forks source link

Asset links to open in new window not working in Navbar (target) #68

Closed bgarrant closed 8 years ago

bgarrant commented 8 years ago

When I create a link to open a link to an asset in a new window it is not working. I am sure it could be my code. Any advice?

<nav class="navbar navbar-default">
  <div class="container">
    <div class="navbar-header">
      <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar" aria-expanded="false" aria-controls="navbar">
       <span class="sr-only">Toggle navigation</span>
       <span class="icon-bar"></span>
       <span class="icon-bar"></span>
       <span class="icon-bar"></span>
     </button>
     {# <a class="navbar-brand" href="{{ siteUrl }}">{{ siteName }}</a> #}
   </div>
   <div id="navbar" class="navbar-collapse collapse">

     {% set nav = craft.amNav.getNavRaw("mainNavigation") %}

     {% macro addPageToNavigation(page) %}
     {% if page.children is defined %}
     <li class="dropdown">
       <a href="{{ page.url }}" class="dropdown-toggle" data-toggle="dropdown" data-hover="dropdown">{{ page.name }} <b class="caret hidden-md hidden-lg"></b></a>
       <ul class="dropdown-menu nav-nocaps">
         {% for subpage in page.children %}
         {{ _self.addPageToNavigation(subpage) }}
         {% endfor %}
       </ul>
     </li>
     {% else %}
     <li><a href="{{ page.url }}" title="{{ page.name }}">{{ page.name }}</a></li>
     {% endif %}
     {% endmacro %}

     <ul class="nav navbar-nav nav-caps">
      {% for page in nav %}
      {{ _self.addPageToNavigation(page) }}
      {% endfor %}
    </ul>

  </div><!--/.navbar-collapse -->
</div>
</nav>
bgarrant commented 8 years ago

I fixed it with this...{% if page.blank %} target="_blank"{% endif %}