search

am15h / tflite_flutter_plugin

TensorFlow Lite Flutter Plugin
https://pub.dev/packages/tflite_flutter
Apache License 2.0
499 stars 352 forks source link

IMPORTANT - Maintainer / Code Owner Request #221

Closed walsha2 closed 1 year ago

walsha2 commented 1 year ago

Background

Attempts at reaching @am15h have not worked. This repo is slowly getting very stale and breaking. It is 100% understandable if the original maintainers no longer have the time to support the plugin. Can we open the package to other maintainers? tflite_flutter already has 300+ likes on pub.dev. It would be better to keep this package up to date rather than create clones with similar names and confuse users.

Request

Are there any repo members that are code owners or maintainers that have write access to the repo so that this can continue to be maintained by the community? Otherwise, this repo can be considered dead and will end up with a series of copies flooding pub.dev. It is preferable to continue to maintain this repo instead - we just need someone with write access to allow for pull requests to be merged.

JengaAttack commented 1 year ago

Sorry can i ask, are there any good cloned maintained repos ATM?

uayodev commented 1 year ago

I agree walsha2, there are many packages that I can't use or have to use several older versions because the tflite_flutter package depends on the older versions. The same thing happens to me with the tflite_flutter_helper package

PaulTR commented 1 year ago

So I just got a message about this ticket and wanted to provide an update. The TensorFlow team has officially taken ownership of the pub.dev package and will be working to migrate this code over to the official TensorFlow GitHub org/repo. I'll try to remember to post here as soon as that's done, and I'll get a message up on the pub.dev page. It might take me like a month with IO and other stuff, but it's definitely in the works now!

yaizudamashii commented 1 year ago

Wow what an amazing news! Long live TensorFlow and Flutter!

walsha2 commented 1 year ago

@PaulTR that is fantastic news. Thank you for updating us and also appreciate you updating the pub.dev release with the following message. This should help warn users.

The TensorFlow team has taken official ownership of this plugin and will begin migrating to the TensorFlow org with a team managed repo. You can follow the package on pub.dev for updates as we make progress. Our goal is to have this moved over by mid-May, then we'll start work on updates and accepting community contributions.

https://pub.dev/packages/tflite_flutter

When the time is appropriate, please mark the tflite_flutter package as discontinued so that users no longer use this package.

PaulTR commented 1 year ago

We'll actually use the same package :) I'm just getting the repo under us rather than am15h. Will update and point it as 0.9.x when it's moved, then I think the next big goal is updating dependencies so it isn't restricting people trying to use it.

charlieforward9 commented 1 year ago

@PaulTR amazing, thanks for updating us! Will we potentially see a merge with the helper package as well?

charlieforward9 commented 1 year ago

@PaulTR Thanks for all the details! I am still relatively new to the ML space but am working on a product that directly depends on this framework and some MediaPipe Solutions.

With that said, I would like to hear how closely TensorFlow and MediaPipe are working together on a Flutter solution. I opened this issue a few months ago and haven't heard back, wondering if you have any insight on this?

mdejeans commented 1 year ago

@PaulTR amazing, thanks for updating us! Will we potentially see a merge with the helper package as well?

I've contributed on this package a long time ago. @PaulTR @walsha2 if you need any help maintening/merging/reviewing things, it will be with pleasure, just reach me out !

PaulTR commented 1 year ago

Hey @mdejeans I'll keep everyone posted. Right now I'm working through a ridiculous number of processes to get this moving forward internally :)

PaulTR commented 1 year ago

@charlieforward9 We're the same team :) I actually mostly work on MediaPipe, but trying to drive Flutter for TensorFlow since it already exists and just needs a little love.

charlieforward9 commented 1 year ago

That's good to know. I agree with you! Thanks for putting in the work for us internally!

JSYRD commented 1 year ago

Amazing news! Finally got an official plugin for tflite! So should we contribute to this repo, or latter to the migrant repo?

PaulTR commented 1 year ago

Go ahead and contribute here. I'll review PRs before moving things over once that's all prepared (still in process, but I have high hopes!) :) I'll try to sit down this week to get the plugin working on my machine for Android so I have a baseline for reviews.

On Sat, Apr 22, 2023, 8:47 PM JSYRD @.***> wrote:

Amazing news! Finally got an official plugin for tflite! So should we contribute to this repo, or latter to the migrant repo?

— Reply to this email directly, view it on GitHub https://github.com/am15h/tflite_flutter_plugin/issues/221#issuecomment-1518925767, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAR2C366I3EC27OHJDGMTNLXCSJ23ANCNFSM6AAAAAAUW274KI . You are receiving this because you were mentioned.Message ID: @.***>

JSYRD commented 1 year ago

Thank you! Now I've built the latest tflite binary and it worked successfully. Obviously the wiki needs updating, so do the releases, but maybe you can provide some official binaries as releases after migrant, rather than those built on our own. :) This plugin did help me a lot! I'll try to update the wiki.

Alexi-Zemcov commented 1 year ago

I'll try to sit down this week to get the plugin working on my machine for Android so I have a baseline for reviews.

Hello @PaulTR. I just created a PR for tflite_flutter_helper with a working example. Maybe this will help you somehow.

Alexi-Zemcov commented 1 year ago

...but maybe you can provide some official binaries as releases after migrant, rather than those built on our own

@JSYRD do you know how to build the binaries? When I tried to build them, I only got the framework for ios, but I couldn't build the android binary. If you have fresh binaries, can you share them, please?

JSYRD commented 1 year ago

...but maybe you can provide some official binaries as releases after migrant, rather than those built on our own

@JSYRD do you know how to build the binaries? When I tried to build them, I only got the framework for ios, but I couldn't build the android binary. If you have fresh binaries, can you share them, please?

Yes I do, please check this: https://github.com/JSYRD/krccsnet/releases

PaulTR commented 1 year ago

Hey everyone! Time for the followup we've all been waiting for.

The repo has been officially moved over to the TensorFlow org in its current state. It's definitely going to take some time to update everything and get this to a runnable state, but I'm starting that long process now :) I'll first focus on all of the fun house-keeping things like repo management, copyright headers, and figuring out what documentation should be marked for updates. With some luck that'll be in a good place within a few weeks (though that could very likely fall behind as we approach I/O), then I'll start trying to get this building for mobile (Android + iOS). I want to say that I'll be able to get everything going for web+desktop not long after, but I honestly just don't know since those are a bit more out of my wheelhouse.

Similar to before, PRs are very much welcome in the new repo, especially during this ramp up time, so I'm definitely looking forward to the community applying their expertise as this moves forward.

Thanks all!

mirland commented 1 year ago

@PaulTR Thanks for the update. However, why did you create a new repo? In my opinion, you should transfer the repo (so the issues, history, and contributors are transferred), you shouldn't just copy it.

Also if you don't want to transfer it, you could just fork it, but as an OSS vision, you should not just drop the current state. For example, a lot of years ago, Google took the work started by Square, and they forked dagger (and they make it much better) In that case Google was not the owner of Dagger, now you have the ownership here, that is why I think transferring is better than forking in this case.

That's just an opinion

PaulTR commented 1 year ago

@mirland Short answer is politics :) Internal systems with legal review for creating repos under our orgs and all that fun stuff.

mirland commented 1 year ago

Ok, in this case, I would add documentation in the readme telling that the new repo is hosted in the tf org(it's already done), then I'd close this issue and at the end, I'd archive this repository.

PaulTR commented 1 year ago

Closing the issue, but I don't actually have admin rights on this repo. Can't archive it myself.