amPerl / egui-phosphor

Phosphor icons for egui
Apache License 2.0
98 stars 25 forks source link

Update to egui v0.26 #11

Closed njust closed 8 months ago

njust commented 8 months ago

Updated to egui v0.26 and checked the multiple_variants example, which looked fine.

gmarull commented 8 months ago

I'd also like to get this upgrade. Shouldn't version bump be dropped from 041ff40?

athre0z commented 8 months ago

At the very least it should bump to 0.4.0 instead of 0.3.2. Bumping just the patch is violating semver: doing cargo update will break everyone's build unless they also (manually!) bump their egui dependency.

njust commented 8 months ago

I followed the scheme of the egui update v0.24 to v0.25, where the version of egui-phosphor was bumped from 0.3.1 to 0.3.2.

egui update: https://github.com/amPerl/egui-phosphor/commit/c44a0c6bf9893515019f517a5ba1265057149949 version bump: https://github.com/amPerl/egui-phosphor/commit/1ca1953314cc7cbd446f63fa8f8106e8eceb40ae

amPerl commented 8 months ago

At the very least it should bump to 0.4.0 instead of 0.3.2. Bumping just the patch is violating semver: doing cargo update will break everyone's build unless they also (manually!) bump their egui dependency.

I'll major bump it on top of this. thanks