search

amPerl / egui-phosphor

Phosphor icons for egui
Apache License 2.0
98 stars 25 forks source link

bump egui to 0.27 #12

Closed hacknus closed 6 months ago

hacknus commented 6 months ago

@amPerl Can I ask why it was favored to add egui 0.27 as a hard requirement instead of making it able to use 0.26 and 0.27 as in this PR?

Just as a note, because not many people seem to be using this feature, you can specify a version range, like ">=0.26.0,<=0.27.0", so it both supports 0.26 and 0.27

as mentioned by @crumblingstatue

amPerl commented 6 months ago

Well the short answer is I sat down to get this crate bumped and didn't plan on thinking about the semver implications of specifying a range rather than a fixed version at that same moment. I'm guessing doing it like this means I get to bump minor only in the future?

hacknus commented 6 months ago

well, with the requirement of a specific version of egui all users need to upgrade egui if they want to use a new version of egui-phosphor, and there might be breaking changes... it's likely that they will fork egui-phosphor if they do not want to update egui in that case.