search

ama-chi / pe

0 stars 0 forks source link

Untag does not work on edited tags (When there are multiple) #4

Open ama-chi opened 1 year ago

ama-chi commented 1 year ago

To reproduce

  1. Edit a store to contain at least 2 tags

Screenshot 2022-11-11 at 4.55.51 PM.png

  1. Try to untag one of the given tags

Screenshot 2022-11-11 at 4.56.21 PM.png

Expected: Tags to be removed

Actual: Tags cannot be removed

Screenshot 2022-11-11 at 4.56.53 PM.png

As editing an entry is a commonly used feature, being unable to use untag to remove edited tags would cause an inconvenience to many users.

nus-pe-bot commented 1 year ago

Team's Response

Similar issue to #1339, linked here.

The root cause is the tester mistakenly using one -t prefix for multiple tags. We believe that there is enough information in the UG that each tag should be preceded by a t prefix.

He should have run tag 1 -t mala -t spicy instead of tag 1 -t mala spicy, as the latter would result in NUSEatWhere treating mala spicy as an individual tag. Thus, untag would not work for this tester.

The app is working as intended.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]