search

amacati / SoulsGym

Gymnasium extension for DarkSouls III, Elden Ring, and other Souls games
MIT License
115 stars 9 forks source link

is strong attack z or y? #47

Closed anxuthu closed 1 year ago

anxuthu commented 1 year ago

here in the doc, strong attack is mapped to keyboard 'z', but in keys.yaml, it's mapped to 'y'.

Would this be an issue?

amacati commented 1 year ago

Good catch ;) I am German, and on the German keyboard layout, z and y are swapped. With my setup, everything works as intended, but if you change the layout to qwerty, you won't be able to do heavy attacks.

I should probably add a keyboard check on initialization or change the key to a character that is consistent across both layouts. I think it's easier to go for the latter solution because of the amount of layouts that are out there.