search

amacd31 / kiwis_pie

Python library for querying WISKI via KiWIS (KISTERS Web Interoperability Solution)
Other
17 stars 7 forks source link

added verify option to request #4

Closed andyrich closed 1 year ago

andyrich commented 1 year ago

some wiski/kiwis servers have certificate issues. adding verify allows for either skipping security OR providing certificate for given server. default remains as True for verify.

amacd31 commented 1 year ago

This is a good feature request. Given it is dealing with an issue at the server level I've added a commit to make it an argument on the KIWIS class. With a verify_ssl argument stored in self.verify_ssl. Then calling requests.get can pass verify = self.verify_ssl (and not need to be explicitly passed to every method on the KIWIS object being used).

Also added to the class docstring regarding the verify flag.

I'm happy to merge this PR now. Thanks for raising the initial PR.

amacd31 commented 1 year ago

@andyrich, just as an FYI this is now included in the now released version 0.10.3.