search

amachanic / sp_whoisactive

sp_whoisactive
GNU General Public License v3.0
1.13k stars 281 forks source link

[FIX] Remove last_request_end_time predicate #70

Open amachanic opened 2 years ago

amachanic commented 2 years ago

I think this will fix various bugs. On the flip side, I have no idea what problems it will cause. This predicate was in place for about a decade and I can't remember why I put it in place.

erikdarlingdata commented 2 years ago

@amachanic not sure what happened here, but essentially the whole PR is a conflict. It might be easier to re-base and make the one change again.

amachanic commented 2 years ago

@amachanic not sure what happened here, but essentially the whole PR is a conflict. It might be easier to re-base and make the one change again.

I removed all of the tabs and switched to spaces.

erikdarlingdata commented 2 years ago

@amachanic not sure what happened here, but essentially the whole PR is a conflict. It might be easier to re-base and make the one change again.

I removed all of the tabs and switched to spaces.

Yeah, I caught that PR, but the diff wasn't loading here for a bit. Would you prefer to rebase with the spaces commit in place or just resolve this one?