search

amachanic / sp_whoisactive

sp_whoisactive
GNU General Public License v3.0
1.18k stars 290 forks source link

Feature: Add encrypted information into session output #79

Open dalehhirt opened 2 years ago

dalehhirt commented 2 years ago

The sys.dm_exec_connections DMV contains an encrypt_option column. I would like to add that into the output.

amachanic commented 2 years ago

Can you provide some more background on why you want this information? Especially, looking at your implementation, why you'd want to be able to filter on this?

Reading your initial request, I was inclined to throw this information into the [additional_info] collection, rather than creating a whole new column. I was also not inclined to create a new top-level option for it, let alone a new filter mode. The implementation you've provided is fairly involved for something that -- to me, at least -- seems like a purely informational thing.

Happy to reconsider my stance here - please educate me on the use cases you're hitting.

dalehhirt commented 2 years ago

Hi Adam,

My use case is fairly straight forward. We are moving to turn on force encryption across all of our SQL servers. I need to be able to do two things:

  1. gather programs that are accessing our systems unencrypted to contact their owners to upgrade their connection strings
  2. Report progress of encrypted vs unencrypted connections to management.

While I don't know if this is the best implementation, I chose the parameter method so it won't break anyone's existing scripts.

Thanks,

Dale

On Fri, Feb 25, 2022, 9:31 AM Adam Machanic @.***> wrote:

Can you provide some more background on why you want this information? Especially, looking at your implementation, why you'd want to be able to filter on this?

Reading your initial request, I was inclined to throw this information into the [additional_info] collection, rather than creating a whole new column. I was also not inclined to create a new top-level option for it, let alone a new filter mode. The implementation you've provided is fairly involved for something that -- to me, at least -- seems like a purely informational thing.

Happy to reconsider my stance here - please educate me on the use cases you're hitting.

— Reply to this email directly, view it on GitHub https://github.com/amachanic/sp_whoisactive/issues/79#issuecomment-1051051878, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAREL32NPQGBLPLM7KLVPV3U464IRANCNFSM5NLFQQ4A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

dalehhirt commented 1 year ago

New PR #92

Not sure what's up with the line-inserting issue. I didn't change anything on my end.