search

amadejkastelic / discord-video-embed-bot

A discord bot that automatically embeds videos from various sources that do not support embeding.
GNU General Public License v3.0
9 stars 2 forks source link

Add Compact Post Mode #3

Closed binaryn3xus closed 4 months ago

binaryn3xus commented 4 months ago

Purpose: Content creators can be extremely annoying with posting 30+ hashtags per video or other useless long information. Adding this feature I think will be beneficial for if someone just wanted the URL (in case it false to load) and the video itself.

Requirement:

Additional: In updating the README, I added a table that describes the additional options. This allows for the project to grow in some of the options available. Also while in here, I did a little clean up based on linting suggestions. Hope that is okay.

I'm very green to Python other than training videos and small projects, so please feel free to give advice or suggestions.

amadejkastelic commented 4 months ago

Thanks for the contribution. You usually don't want to work with environment specific stuff in the domain layer. The env variable should be read outside and passed in constructor. I'll still merge this and create a new tag.

FYI: I'm currently working on a big rewrite on dev branch and I've already implemented something similar - the ability to set post format per integration and hold configs in DB. It's not quite ready yet..

amadejkastelic commented 4 months ago

Tagged and built https://github.com/amadejkastelic/discord-video-embed-bot/pkgs/container/discord-video-embed-bot/251131499?tag=0.20.3