search

amadeus4dev-examples / amadeus-android

Android (Kotlin) library for the Amadeus Self-Service travel APIs
https://developers.amadeus.com/
MIT License
19 stars 8 forks source link

Update gradle publish #74

Closed torresc24 closed 2 years ago

torresc24 commented 3 years ago

Publishing library to MavenCentral

Changes for this pull request

Publish Gradle and remove travis file

Checklist

Update project build gradle file Update publish gradle file Update gradle.properties file

torresc24 commented 2 years ago

I tried to publish the new artefact locally using ./gradlew publishMavenLocal I'm able to get the binaries correctly. But there is a problem with the .pom a dependency is declared as unspecified and it prevents the dependencies resolution. Steps to reproduce:

  • Use ./gradlew publishMavenLocal to generate the 1.3.1 binairies
  • open amadeus-demo project
  • change Amadeus sdk to point to 1.3.1 version.
  • try to launch

On my machine I get the error that there is an unspecified version of a library used in the sdk. You can check that by going into your local .m2 repository and read the amadeus-android-sdk .pom file.

Something else, you're using tabs indent, and the project use 4 spaces indent. You can see clearly the indentation differences on github changed files view.

The issue with the unspecified dependency cames from the filetree dependency. Through https://developer.android.com/studio/build/dependencies is local binary dependency used only geting the binaries. I put a condition to not have in consideration the fileTree when is generating the pom.

torresc24 commented 2 years ago

The travis.yml file was removed as it will no longer be used for the integration service. A pull-request will be created with changes for using Github Actions.