Fix code smells - part one - Githubissues

amadeus4dev-examples / amadeus-php

PHP library for the Amadeus Self-Service APIs

https://amadeus4dev-examples.github.io/amadeus-php/

MIT License

11 stars 13 forks source link

Fix code smells - part one #81

Closed xianqiliu closed 2 years ago

xianqiliu commented 2 years ago

/src/client/Response.php

[x] Local variables should not have the same name as class fields https://github.com/amadeus4dev/amadeus-php/blob/32d6cffa5009ef8e3665e9703cca6e52554d8a68/src/client/Response.php#L41 https://github.com/amadeus4dev/amadeus-php/blob/32d6cffa5009ef8e3665e9703cca6e52554d8a68/src/client/Response.php#L195
[x] Collapsible "if" statements should be merged https://github.com/amadeus4dev/amadeus-php/blob/32d6cffa5009ef8e3665e9703cca6e52554d8a68/src/client/Response.php#L199-L201

/src/exceptions/

[x] Overriding methods should do more than simply call the same method in the super class e.g. /src/exceptions/AuthenticationException.php https://github.com/amadeus4dev/amadeus-php/blob/32d6cffa5009ef8e3665e9703cca6e52554d8a68/src/exceptions/AuthenticationException.php#L9-L18