Closed xianqiliu closed 2 years ago
Fixes #81
/src/client/Response.php
[x] Rename $headers (which has the same name as the field declared at line 41) to $headersArray. https://github.com/amadeus4dev/amadeus-php/blob/e3ec95bb3a356a110a5233a9670632bf05e187fb/src/client/Response.php#L41 https://github.com/amadeus4dev/amadeus-php/blob/e3ec95bb3a356a110a5233a9670632bf05e187fb/src/client/Response.php#L195
$headers
$headersArray
[x] Merge this if statement with the enclosing one. https://github.com/amadeus4dev/amadeus-php/blob/e3ec95bb3a356a110a5233a9670632bf05e187fb/src/client/Response.php#L199-L201
/src/exceptions/
__construct
/src/exceptions/AuthenticationException.php
The Sonar result after merging this PR: (Code smells counts: from 65 -> 58)
Fixes #81
/src/client/Response.php
[x] Rename
$headers
(which has the same name as the field declared at line 41) to$headersArray
. https://github.com/amadeus4dev/amadeus-php/blob/e3ec95bb3a356a110a5233a9670632bf05e187fb/src/client/Response.php#L41 https://github.com/amadeus4dev/amadeus-php/blob/e3ec95bb3a356a110a5233a9670632bf05e187fb/src/client/Response.php#L195[x] Merge this if statement with the enclosing one. https://github.com/amadeus4dev/amadeus-php/blob/e3ec95bb3a356a110a5233a9670632bf05e187fb/src/client/Response.php#L199-L201
/src/exceptions/
__construct
to simply inherit it. e.g./src/exceptions/AuthenticationException.php
https://github.com/amadeus4dev/amadeus-php/blob/32d6cffa5009ef8e3665e9703cca6e52554d8a68/src/exceptions/AuthenticationException.php#L9-L18The Sonar result after merging this PR: (Code smells counts: from 65 -> 58)