Fix code smells - part two - Githubissues

amadeus4dev-examples / amadeus-php

PHP library for the Amadeus Self-Service APIs

https://amadeus4dev-examples.github.io/amadeus-php/

MIT License

11 stars 13 forks source link

Fix code smells - part two #84

Closed xianqiliu closed 2 years ago

xianqiliu commented 2 years ago

Fixes #83 (see details on the issue)

[x] Fix: String literals should not be duplicated
[x] Fix: Local variables should not have the same name as class fields
[x] Fix: Track uses of "TODO" tags
[x] Fix: Source files should not have any duplicated blocks
[x] Fix: Functions should not have too many lines of code

The Sonar result after merging this PR (plus already merged PR #82) :

Code smells counts: from 58 to 41 Duplication: from 1.3% to 1.2%