search

amadeus4dev-examples / amadeus-php

PHP library for the Amadeus Self-Service APIs
https://amadeus4dev-examples.github.io/amadeus-php/
MIT License
11 stars 13 forks source link

set up GitHub pages for this repo to make the documentation link work #93

Closed xianqiliu closed 2 years ago

xianqiliu commented 2 years ago

@jabrena @tsolakoua @minjikarin hey, although I saw the warning that the Amadeus for Developers team will not support or maintain this SDK, however, since this repo has been transferred to another organization, which means the URL for the PHP documentation should be changed too. Thus, please set up GitHub pages for this repo to make the documentation link works again. (Cuz only the admin user of this organization can set up GitHub pages so I can't contribute to it, you can see more details here) https://github.com/amadeus4dev-examples/amadeus-php/blob/2f09497cf4df068de86eda43cc716478412ce1a9/README.md?plain=1#L136 In addition, the link in the place shown below should also be changed. image

xianqiliu commented 2 years ago

@jabrena @tsolakoua @minjikarin really hope this issue could be fixed ASAP, please! thank you :)

tsolakoua commented 2 years ago

So nice to hear from you @xianqiliu :) Just created a PR with the change as well as the link to the main repo page.

xianqiliu commented 2 years ago

@tsolakoua Nice! Just a reminder for next time, I think the best practice is to create a PR from your forked repo. Cuz every time you create a branch from the original repo, it will be also automatically updated on Packagist as shown below. image

tsolakoua commented 2 years ago

That's true!!! Thanks @xianqiliu for the reminder! I deleted the additional packages created by the PRs.