PR for the SeatMap feature.

amadeus4dev-examples / amadeus-php

PHP library for the Amadeus Self-Service APIs

https://amadeus4dev-examples.github.io/amadeus-php/

MIT License

11 stars 13 forks source link

PR for the SeatMap feature. #96

Closed johandavidsen closed 1 year ago

johandavidsen commented 1 year ago

Fixes #62

Changes for this pull request

Implemented the SeatMap API GET and POST requests.

Checklist

Ensure all tests pass and linting
Ensure this PR only changes what it is intended to change

johandavidsen commented 1 year ago

I consider this to be feature complete. Please let me know, if anything is missing?

xianqiliu commented 1 year ago

I consider this to be feature complete. Please let me know, if anything is missing?

@tsolakoua @minjikarin Hey guys, this PR looks good to me. Please do a double review and go ahead with this PR. :/

tsolakoua commented 1 year ago

Thanks for your contribution @johandavidsen and for your review @xianqiliu :) It looks like the build for PHP 8.1 still fails so I am not able to merge the PR it yet.

xianqiliu commented 1 year ago

@johandavidsen hey, as for that failure for building on GitHub actions, I suggest you follow the contributor guide and you will see we need to run the following commands to fix the code style, I believe it would perfectly solve this failure.

vendor/bin/php-cs-fixed fix src 
vendor/bin/php-cs-fixed fix tests

johandavidsen commented 1 year ago

The CS should be fixed now.