search

amadeus4dev / amadeus-java

Java library for the Amadeus Self-Service travel APIs
https://developers.amadeus.com/
MIT License
87 stars 69 forks source link

Make delays in DatedFlight.Timing accept an array #179

Closed frankkoornstra closed 2 years ago

frankkoornstra commented 2 years ago

Delays is an array of Delay, not an object.

Fixes #178

Changes for this pull request

Checklist

Tests are all :heavy_check_mark:

jabrena commented 2 years ago

Hi @frankkoornstra, It is necessary to upload the tests in the PR. Any PR is an atomic operation for a new consistent state in the library.

frankkoornstra commented 2 years ago

All tests are actually :heavy_check_mark: so all good. Apparently this isn't covered by tests at all so I hope I'm not expected to create an entire integration test while fixing this bug :grimacing: I'm trying to do the right thing here by posting the issue and creating a patch :slightly_smiling_face:

frankkoornstra commented 2 years ago

@jabrena can this be merged, please? This isn't a minor bug, it's making the whole flight lookup feature unusable with the many delays we have in the past weeks.

jabrena commented 2 years ago

Hi mate, tomorrow, I will work on it. :)

jabrena commented 2 years ago

Hi @frankkoornstra,

First, apologies by the delay because you were right with this PR. I was checking the portal and our OAS files and yes, Timing objects returns an array of Delays.

OAS Evidence: https://github.com/amadeus4dev/amadeus-open-api-specification/blob/main/spec/json/OnDemandFlightStatus_v2_swagger_specification.json

Portal Evidence: https://developers.amadeus.com/self-service/category/air/api-doc/on-demand-flight-status/api-reference

image

frankkoornstra commented 2 years ago

Nice, thanks! When do you think a new version will be released with this patch included?

tsolakoua commented 2 years ago

Hello @frankkoornstra , you can now install and use the version 6.2.0