The recent pull request (PR: #207) titled "Removed Bluebird Dependency" aimed to eliminate the usage of the Bluebird library, making the codebase lighter and potentially faster. However, the build checks for this pull request have failed due to permission issues when trying to access the remote repository.
Changes Made:
Removed the Bluebird library and implementation from the codebase.
Updated methods to use native JavaScript promises instead of Bluebird, following the recommendation on the Bluebird GitHub page.
Additional Information:
The Bluebird GitHub page suggests using native promises if at all possible, and this change aligns with that recommendation.
The codebase didn't utilize any specific Bluebird methods, further justifying the removal of the dependency.
The bearerToken method, documented to return a Bluebird Promise in JSDocs, yet it was using the native JavaScript Promise.
Build Failure Details:
The build failure occurred due to permission issues while accessing the remote repository. The following error messages were displayed in the logs:
remote: Permission to amadeus4dev/amadeus-node.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/amadeus4dev/amadeus-node.git/': The requested URL returned error: 403
Error: The deploy step encountered an error: The process '/usr/bin/git' failed with exit code 128
Versions
[What version of Node/NPM are you running? What Operating System are you on?]
Issue Description:
The recent pull request (PR: #207) titled "Removed Bluebird Dependency" aimed to eliminate the usage of the Bluebird library, making the codebase lighter and potentially faster. However, the build checks for this pull request have failed due to permission issues when trying to access the remote repository.
Changes Made:
Additional Information:
bearerTokenmethod, documented to return a Bluebird Promise in JSDocs, yet it was using the native JavaScript Promise.Build Failure Details:
The build failure occurred due to permission issues while accessing the remote repository. The following error messages were displayed in the logs:
Versions
[What version of Node/NPM are you running? What Operating System are you on?]
Checklist
Please make sure you checked the following: