amadornes / SCM-Localization-Issues

Localization and issues for Super Circuit Maker
16 stars 19 forks source link

Circuit errors when activated #247

Open MicobyteMichael opened 7 years ago

MicobyteMichael commented 7 years ago

I am attempting to build a 4bit RAM circuit for a redstone computer. However, whenever I activate the clock (store data from input), the circuit becomes the blue "error" circuit. It seems to be caused by having a circuit-within-a-circuit-within-a-circuit, because whenever I place the circuit-within-a-circuit on any circuit and activate it, it becomes the "error" circuit.

Here is the error-report Gist: https://gist.github.com/anonymous/de21556cd2937074731eb8ba761cdf8e Here are screenshots: http://imgur.com/a/2NtQb

(The third one is the one that breaks when you power it on the left side.)

Thanks! Sincerely, MicobyteMichael

dokranke commented 7 years ago

I guess it isn't a circuit-within-a-circuit error, because some of mine also error when activated without a circuit. I think the reason is more the complexity.

Found the issue: in the tick method something causes the components to recursivly propagate/update each other causing the stacktrace to fill up and crash the circuits

MicobyteMichael commented 7 years ago

Thanks for helping me confirm! Now let's hope Ama can get this fixed! Would've assumed it was some sort of infinate propogation, as per the Stack Overflow, but I didn't see a repo here in order to look at the code and be sure before being quite so specific.

dokranke commented 7 years ago

Well you could decompile the jar to look in the code, but i its not really neat. He has his reasons.