amadornes / SCM-Localization-Issues

Localization and issues for Super Circuit Maker
16 stars 19 forks source link

Non-conductive plate dupe bug #68

Open Ristellise opened 7 years ago

Ristellise commented 7 years ago

When a conductive plate is placed. and is at it's last stack.. when placed it returns a 0 item conductive plate. EDIT : happens when inventory tweaks is installed. (note image heavy) 2016-11-05_21 24 42 (you can see a 0 number... and is placeable..) 2016-11-05_21 24 44 2016-11-05_21 24 47 2016-11-05_21 24 56

amadornes commented 7 years ago

This happens with all items, not just the nonconductive plate. It's been there from the beginning and I'm still looking for a fix :/

Ristellise commented 7 years ago

we could detect for the players inventory for a null number of items from the mod and remove it before it gets placed.

Ristellise commented 7 years ago

or we get the number of items. eg : 1. if it was placed it should be 0 and remove the item.

gudenau commented 7 years ago

You could make the item's onUpdate check for a stack of zero as a hack to fix this.

wesserboy commented 7 years ago

I had the same issue, i noticed that it turns another SCM component from your inventory into the one with the 0 stack instead of just duping it. If you don't have any other SCM components in your inventory, it will still create the 0 stack, but you can't place it. It probably has something to do with inventory tweaks putting another component in that slot when the 0 stack runs out.

In the images in the top post you can see that the glowing redstone goes from 12 to 11 when he places the 0 stack non-conducting plate.

Ristellise commented 7 years ago

yeah inventory tweaks was installed. icmentioned it earlier.

amadornes commented 7 years ago

Then yeah, it's a combo of the 0-stacksize bug and inventory tweaks re-filling the slot. What surprises me, though, is that invtweaks doesn't notify the player of the inventory update either... Will look into it :)

gudenau commented 7 years ago

I managed to get this to happen with only JEI, SCM and Multipart.