New feature, capture gutter elements - Githubissues

amaembo / screenshoter

IDEA plugin to make code screenshots

Other

87 stars 16 forks source link

New feature, capture gutter elements #13

Closed enihsyou closed 5 years ago

enihsyou commented 5 years ago

Major change:

Migrate to Gradle build system
Ability to include gutter in screenshot
Options to toggle line number, gutter icons, indent guide... in shot #4 #9 #10
Simplified Chinese localization
Soft wrap awareness
Capture full editor when nothing is selected

Bug fix:

Bugs in chop indentation #8

Caveat:

Not fully test on older version of IntelliJ
Does not use new implementation if gutter capture feature is off
Caret row is still highlighted in full capture mode, with current selected element highlighted
LoDPI gutter icons

Todo:

Remove old implementation
Add dialog for quick toggling features between on and off
Add an option to switch off inspections in screenshot

Also, I did not update plugin.xml.

Preview below, with padding set to 10 Preview with padding set to 10

amaembo commented 5 years ago

Hello! Thank you for your contribution.

Unfortunately this is a very big change for single code review. Please split it into several separate changes, one feature per PR (localization, soft wrap, gutter icons, line numbers), so it will be easier to perform a review.

Also I'm not convinced that migration to Gradle is necessary for this project. And I definitely reject the removal of idea configurations like code style.