search

amaembo / screenshoter

IDEA plugin to make code screenshots
Other
88 stars 17 forks source link

Design change #20

Closed AppLoidx closed 4 years ago

AppLoidx commented 4 years ago

This PR contains 3 points:

Plugin Icon

Added simple plugin icon which uses action colors and specification from JetBrains

image

myPadding default property

was:

image

now:

image

Examples in README

I hope you will not mind about html tags in markdown, because github supports it, but I'm not sure it will be work on all markdown readers

Screenshots saved in screenshots dir

And sorry about one big PR :)

AppLoidx commented 4 years ago

works on IntelliJ IDEA 2020.2 EAP (Ultimate Edition)

amaembo commented 4 years ago

Thank you for your PR.

  1. I don't like the idea of default padding. 15 may be ok for your purposes but it's not ok for my purposes. If you paste to the place with matching background color (e.g. presentation slide), you don't need padding at all, it's just a file size waste. Also, the padding size will look different depends on the font size, monitor scale, and the selected scale factor. So, to me, 0 is the only reasonable default. It doesn't take so much time for users to change it if necessary. Please rollback this change.

  2. Posted screenshots are too big. Is it really necessary to have 6Mpix image in readme?

AppLoidx commented 4 years ago

Okay, thank you for your fast reply. If you don't mind about logo - I can make one another PR for it (only logo).

amaembo commented 4 years ago

Thanks.