amaggiulli / QLNet

QLNet C# Library
https://amaggiulli.github.io/QLNet/
BSD 3-Clause "New" or "Revised" License
381 stars 175 forks source link

Fixing outdated sonarqube and adding dotnet core tests #248

Closed potatman closed 4 years ago

igitur commented 4 years ago

I think you guys were a bit quick to just drop a target framework. We were explicitly supporting older versions of Visual Studio through the QLNetOld.sln and QLNet.Old.csproj files. That project relies on a net452 build. If we drop .NET Framework support, that means people who build QLNet themselves will require a later version of Visual Studio and hence we can drop the "old" .sln and .csproj files. At the moment we're sitting with a half-baked implementation.

So do we want to support older version of Visual Studio (and then also .NET 4.5.2) or do we decide that every developer should be on a later (I think 2017+) version of Visual Studio?