Project reference to QLNet in samples and consolidated props file

amaggiulli / QLNet

QLNet C# Library

https://amaggiulli.github.io/QLNet/

BSD 3-Clause "New" or "Revised" License

387 stars 174 forks source link

Project reference to QLNet in samples and consolidated props file #264

Closed igitur closed 2 years ago

igitur commented 3 years ago

This PR does 2 things

For the samples projects, changes the QLNet package reference to a project reference. This makes it easier to debug. We can discuss this if you disagree
Adds a new QLNet.props which contains shared project attributes. Make all projects reference this shared props file

igitur commented 3 years ago

@amaggiulli So, in the future, when you want to bump the version, you will now have only 1 file to edit: QLNet.props

amaggiulli commented 3 years ago

@igitur looks good, about samples I'm not sure what the best for users, currently they can run/debug samples withut the need to build QLNet, also when working on QLNet it do not compile samples on each changes, but now that samples are in separate solution maybe is not an issue.

igitur commented 3 years ago

@igitur looks good, about samples I'm not sure what the best for users, currently they can run/debug samples withut the need to build QLNet, also when working on QLNet it do not compile samples on each changes, but now that samples are in separate solution maybe is not an issue.

How do most users use the samples at the moment? If they're using the sample code, are they not cloning the entire repo, in which case the QLNet project would be available too? I thought that this would be the general case.

I can drop that commit if you prefer.

amaggiulli commented 2 years ago

closing for now