Open vsagarv opened 1 year ago
you are right. i think that @shashi-banger has already modified them as you have mentioned. see https://github.com/amagimedia/metadata/blob/main/amgrss_schemas/amgrss_xpaths_description.csv
The updated example https://github.com/amagimedia/metadata/blob/ks--amgrss-master-eg-1/amgrss_schemas/amgrss_master.xml (in the branch ks--amgrss-master-eg-1
reflects that).
@vsagarv, saar, if this makes sense please close the issue or else wait for the branch to be merged with main before you close it (after due verification).
@ksridhar Thank you. I should have checked the xpaths description. I will update the schema accordingly and then mark this issue as closed.
@ksridhar @shashi-banger On this note, should we rewrite the schema[0|1|2].xsds to be inline with https://github.com/amagimedia/metadata/blob/main/amgrss_schemas/amgrss_xpaths_description.csv
A side note: After much back and forth, I have one test input finally passing with some modifications to the existing xsls and schema2.xsd
(venv) amgrss-xslts $ amgrss-tool pubrss-2-amgrss --rss-file tests/test_input_data/e67004cc-0.xml --xslt-file xsl_transforms/e67004cc.xsl --output-file /tmp/e67.op
{"name": "amgrss_xslt.amgrss_intmd_transform", "asctime": "2023-03-30 18:33:07,805", "levelname": "INFO", "filename": "amgrss_intmd_transform.py", "lineno": 57, "message": "new process xslt job", "xslt_file": "xsl_transforms/e67004cc.xsl", "rss_file": "tests/test_input_data/e67004cc-0.xml", "output_file": "/tmp/e67_temp.xml"}
Intermediate step completed, moving for post process
Downloading skos schemas ......
No changes to the repository since the last download.
Download Complete!!
Transformation Complete, Starting Validation Step
Validated Output against xsd schema
Time for Post process step: 4.284224987030029
@ksridhar @shashi-banger Why does schema2.xsd have {season|series} prefixes to {Title|Description|Thumbnail} elements when those elements are already inside a season|series element?
Shouldn't the xsd expect plain {title|description|thumbnail} elements just as other un-prefixed elements such as keyword|broadcastDate|productionCompany ?
As a reference, see https://www.ebu.ch/metadata/schemas/EBUCore/ebucore.xsd
(I do understand ebucore#seasonNumber is an independent property.)