search

amagnasco / xwpe

Upload of an abandoned ncurses-based programming environment
http://www.identicalsoftware.com/xwpe/
GNU General Public License v2.0
29 stars 6 forks source link

Edit h refactor #36

Closed gbonnema closed 7 years ago

gbonnema commented 7 years ago

Hi Alessandro,

I have started (EDIT: and finished) a large set of changes for which I am not done yet. I am working on the branche edit_h_refactor, because I want to separate these change from the other changes. Once you integrate into devel, I will synchronize devel.

The file edit.h was is a colleciton of declarations of both extern data and extern functions from several programs. What I have done is refactored most of this collection into the appropriate header files. That way we can see which header files a program really needs.

However. I am not done yet. I have finished the grinding part of the job. Now I am on to a more complex part with declarations of struct and macro defines. That will take more time and more effort. I will probably start a new branch to do this, but only after this one was merged into devel.

If you can have a look at the changes, and confirm whether you want to merge into devel or maybe create your own "edit_h_refactor" branch from devel, then I can continue work on xwpe.

Let me know if you agree with this change.

EDIT: most warnings with gcc compiled (without -Wall) have gone away, because of proper declaration and definition. I only had to change one line of code where the cast was wrong to make the warning go away.

EDIT2: if a definition is for DJGPP only, I will ignore it or delete it as we no longer support DJGPP.

EDIT3: This change now requires a rerun of configure because I changed one of the input files for configure.

gbonnema commented 7 years ago

hey Alessandro,

I run Fedora 25, which is the most current stable version of Fedora. Fedora 26 will be making an appearance somewhere next month.

There are quite a few difference that may cause the problems. The more obvious causes are the difference in versions. Especially Linux v 4.11.3, and gcc v 6.3.1 are interesting changes. Also git is newer (v 2.9.4), but probably gcc is the most important one. This is about one of the standard includes, so most probably GCC version difference is to blame.

Could Travis test Fedora 25 distribution? Or do you need to really install Fedora somewhere? My lack of knowledge of Travis shows, I am sorry about that. As soon as I can I will take a look at the Travis site. Let me know what you need to reproduce a compilation of xwpe from Fedora.

P.S. Your link to the full log file shows a blank page. It really shows "about:blank". This may be due to lack of authorization. It probably is not a public page.

P.S2. We are discussing this in a closed pull request. Should we open an issue for this?

gbonnema commented 7 years ago

I created a new issue for the Travis /. stdio.h business: #46 Include requirements differences due to platform, because the current pull request is closed.