search

amagnasco / xwpe

Upload of an abandoned ncurses-based programming environment
http://www.identicalsoftware.com/xwpe/
GNU General Public License v2.0
31 stars 7 forks source link

Mistyped define for NCURSES #57

Closed gbonnema closed 7 years ago

gbonnema commented 7 years ago

The configure.in file defines CURSES and probably by accident not NCURSES, but CURSES:

14 AC_CHECK_LIB(ncurses, main, 15 LIBS="${LIBS} -lncurses" 16 CURSES="yes" 17 AC_CHECK_LIB(mytinfo, main, LIBS="${LIBS} -lmytinfo"), 18 AC_CHECK_LIB(curses, main, 19 LIBS="${LIBS} -lcurses" 20 CURSES="yes", 21 AC_DEFINE(TERMCAP) 22 AC_CHECK_LIB(termlib, main) 23 AC_CHECK_LIB(termcap, main) 24 ) 25 )

This caused a lot of code to be deactivated that was meant to function if the ncurses library was present. However, when activating ncurses the way it was meant to, the result is more compile errors than expected, and of a type that is not trivial.

The program we_term.c is the one that has most conditional NCURSES code. Later on we should be able to study this and re-integrate ncurses into the code.

For now, all NCURSES code is de-activated (as it was unintentionally done in the code base we have). I decided to leave it de-activated for now.

I will leave this issue open until we can re-integrate ncurses into the code.

gbonnema commented 7 years ago

As you can see this issue is solved using the new autotools and some code changes. It should work as expected now.