amagnasco / xwpe

Upload of an abandoned ncurses-based programming environment
http://www.identicalsoftware.com/xwpe/
GNU General Public License v2.0
29 stars 6 forks source link

Autotools #59

Closed gbonnema closed 7 years ago

gbonnema commented 7 years ago

This patch includes the new versions of Makefile.am and configure.ac. The changes are non-trivial and represent a lot of grinding over de code. Also, I had to take some decisions, that we may need to revert or change later on. Below a summary of what the patch contains. I have the changes in detail summarized in a file called changelog-autotools.md. The git log and diff are of course the most complete and detailed changes.

Related issues are #57, #56, #55, #52, #18.

EDIT: I also managed to eliminate the warnings that Travis shows. My own compiles do not show these warnings, even if I explicitly request these specific warnings. I tested -Wunused-result which is default for gcc-6 and should always show, but they don't.

I hope this summary gives enough information for you to know what was done in the commits of this patch.

Kind regards, Guus.

gbonnema commented 7 years ago

Hey Alessandro,

The weird thing is, that the travis tests show warnings that I do not get from my Fedora system, even though we both use gcc-6. The compile statement mentions no warnings. Are the defaults for warnings in ubuntu different from Fedora? Should we be explicit about what warnings to provide?

Kind regards, Guus

gbonnema commented 7 years ago

Hi Alessandro,

I finished everything I wanted to do on this branch. If you are swamped (many people are), then I will just merge them by the end of tomorrow.

In the meantime I will work on getting ncurses working properly (see #57 for the issue) and if I do before tomorrow night, I will commit it to this branch (autotools) before merging it.

Remark: I am merging straight into experimental, so I will not create a separate branch for these commits on your repo.

gbonnema commented 7 years ago

Hi Alessandro,

This morning I successfully reinstated the full NCURSES functionality (see #57). I also saw that CLANG gives warnings by default that gcc generates for -Wall. So in order to progress in eliminating warnings, I will merge this branch and start a new one for solving the warnings.

Nonetheless, if you have time to checkout the changes sofar and have a look at them, please do.

Kind regards, Guus.

gbonnema commented 7 years ago

This pull request fixes #51, fixes #52, fixes #53, fixes #55 and fixes #57.