amagnasco / xwpe

Upload of an abandoned ncurses-based programming environment
http://www.identicalsoftware.com/xwpe/
GNU General Public License v2.0
29 stars 6 forks source link

Cleanup #69

Closed gbonnema closed 7 years ago

gbonnema commented 7 years ago

Hi Alessandro,

Pull request to do some cleanup and solve #68. More cleanup is still needed. I especially cleaned up the search algorithms so even I can understand what they are doing. I rewrote the basic search algorithms and added some test cases. Also, autotools are now fully integrated into the development cycle. I also added some comment in README.md to account for that.

I will continue working on this branch after I merge it (provided the travis tests are ok.

gbonnema commented 7 years ago

The Travis is working only for clang, not for gcc. All 3 of gcc fail on the loader. I have no idea what is going on, why it is wrong. On my own machine it works, and for clang, but not for gcc. All 3 versions of gcc have a link problem for WpeTermInit and WpeXtermInit. Why? And why clang not? There shouldn't be any difference in linking should there? All is Libtools job.

The only thing I can think of is to combine all in the same library and forget about separating xterm and term. Whether X is around or not, we still need all sources.

Any input is welcome!

gbonnema commented 7 years ago

Alessandro,

The solution to the link problem for make check turned out to be the order of the libxwpe_test.so and libxwpe.so. Apparantly Clang does not have this problem, neither does GCC-7 (my Fedora distribution), but GCC-6 and earlier do.

I really don't know what to say. Is this linking business such a fragile process?

It works, so I merged into experimental. Happy, I am not.