amagnasco / xwpe

Upload of an abandoned ncurses-based programming environment
http://www.identicalsoftware.com/xwpe/
GNU General Public License v2.0
31 stars 7 forks source link

Cleanup2: repair of search / replace #78

Closed gbonnema closed 7 years ago

gbonnema commented 7 years ago

This branch is a cleanup, but also a repair of the replace that did not work properly in combination with undo and redo. Undo followed by redo messed up the text. The cause was a oneliner in the base function for both undo and redo: e_make_rudo, where the length taken was the wrong one.

This is only one step in this intracate piece of programming. The other pieces are block copy, block delete, block paste, and character insertion and deletion. They all are intracately connected to undo / redo and share a lot of complex code. They are for a next refactoring and bugfix action lateron.

I also corrected a missing library that was only missing on Ubuntu. The test library check was apparantly split in to libcheck and libsubunit. On Fedora this is not the case, so I noticed nothing while travis had errors. I connected to travis to my own repo so I will know whether travis will run or not when I do a pull request to your repo.