search

amagovpt / autenticacao.gov

Middleware Oficial de Identificação Eletrónica em Portugal - Cartão de Cidadão, da Chave Móvel Digital e Sistema de Certificação de atributos profissionais
https://www.autenticacao.gov.pt
European Union Public License 1.2
168 stars 33 forks source link

PTEID-POPPLER usages #137

Closed antmonteiro closed 11 months ago

antmonteiro commented 1 year ago

Hello,

Do we really need this library? Can we not use the upstream version which is more updated and more secure?

agrr commented 1 year ago

Hello @antmonteiro,

Pteid-poppler is a fork of poppler we develop for the PDF signature feature since 2012. It already contains a lot of new code in the PDFDoc and Catalog classes so it's not an easy task to re-base the PDF signing feature on current upstream Poppler. The "signature appearance" code in particular is quite complex and specific for our scenario.

Indeed I've been following Poppler development and nowadays there's some overlap as it already incorporates a signing feature as well. It's something to consider in the future, thanks for the suggestion.