search

amagura / eggs

Chicken Scheme eggs I either maintain or wrote
1 stars 1 forks source link

Fix identifier completion #4

Closed wasamasa closed 8 years ago

wasamasa commented 8 years ago

This fixes an annoyance with the existing environment symbol completion: It did complete things like egg#identifier, but left out identifier.

wasamasa commented 8 years ago

Hm, this doesn't work quite right as it fails completing variables and functions defined in the session...

amagura commented 8 years ago

@wasamasa, sorry that I haven't been on lately, umm where you ever able to get it working?

wasamasa commented 8 years ago

Almost forgot about this. Perhaps it's better to do it like in Geiser and just strip that prefix...

wasamasa commented 8 years ago

Would you accept a PR pulling in the apropos egg?

amagura commented 8 years ago

@wasamasa, yes I would accept said PR. Any and all suggestions/changes that improve the egg are welcome here. I'll see about putting some hours in on this PR, maybe I can figure out a way so that it'll complete identifiers even without the egg# prefix, to be fair, though, the completion code is from back before I adopted the egg, and I don't completely understand what it does, but I'll poke around a bit and see if I can figure anything out.

amagura commented 6 years ago

Would you accept a PR pulling in the apropos egg?

@wasamasa did you ever successfully implement this in your own readline implementation?

wasamasa commented 6 years ago

Yes, see: https://github.com/wasamasa/readline/blob/master/readline-scheme-completion.scm