search

amagura / eggs

Chicken Scheme eggs I either maintain or wrote
1 stars 1 forks source link

Unnecessary test dependency? #7

Closed wasamasa closed 8 years ago

wasamasa commented 8 years ago

Now that setup-helper finally deprecated the include usage, a number of eggs broke, including kvlists which is a test dependency for the readline egg. As the test file does only use kvlist?, I wonder whether it's necessary to use this dependency at all. One could easily copy this one definition and just use it.

What could also work is thinking a bit more about the tested variable, readline#session. It is defined as a list with four special keys. Why not test for the presence of each with kvlist-ref or a copied definition instead?

amagura commented 8 years ago

So I copied the definition of kvlist? into the run.scm file and added the author's information to the AUTHORS.