Closed jogendra closed 6 years ago
It's very hard for me to say this. These are great suggestions, however, I feel it may be too much, too early.
I think this is a little overdoing things this early on. This app will probably not be that sophisticated (in terms of state kept, behaviors, views), generally speaking.
Filing PRs to do some iterations (after getting things working) to clean things will be great.
Things that I think we can take this early:
Things that I kind of not agree with or are not the right moment yet
ApiConfig
file.Not sure about the rest.
@cpg We can implement the things you agreed.
UIKit
and Foundation
classes. Please be clear that Extension of our ViewController
and other custom classes should be in the same file. You can read about swift extensions here. Also, you can have a look at SwifterSwift repo for reference.I would suggest you add a link to the coding style guide to the README through a PR.
Development of this project is started just few days ago so I want to create some Reusable components that can be applied to iOS applications developed throughout the organization. Also, I want to propose swift style guide and best ios development practices.
Reusable Components Rather than calling functions and methods again and again, we can create reusable components. This will help us writing clean code and save our time.
UIKit
and some other classes. I added to Dictionary extensionunionInPlace
inNetwork.swift
file, this should be in Extension file. As the development get process, we will need a lot of Extensions.Some other thing I will add in the list.
Style Guidelines To make the code more cleaner and understandable we should follow Swift Style Guide and some best practices for iOS Development. This will help new contributors a lot. I always try to follow this Swift Style Guide. For best iOS practices I want to suggest this good practices.
Suggestion I learn some good things about ios development during last internship and Swift meetups. Some of them I share above and some I want to add here -
SkyFloatingLabelTextField
as a pod, we can drag this file to our project.ViewController
code a lot cleaner and easy to change the value of constants. Ex.