Google cast added in video-player

amahi / ios

Amahi iOS App

https://www.amahi.org/ios

GNU General Public License v3.0

43 stars 65 forks source link

Google cast added in video-player #321

Closed anubhavpulkit closed 4 years ago

anubhavpulkit commented 4 years ago

Description

Google Cast allows users to cast content from a mobile device to a TV. Users can then use their mobile device as a remote control for media playback on the TV. In this PR we add an expanded controller. I'm using google cast official tutorial to add this feature.

Fixes #314

Type of Change:

Code
Quality Assurance
User Interface

How Has This Been Tested?

I can't test this feature because I don't have Chromecast devices to test this feature.

Checklist:

[x] My PR follows the style guidelines of this project
[x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

cpg commented 4 years ago

This does not appear to do anything for me.

However, I have tried

Youtube on my same iOS device, which instantly recognized my cast device (a TV) and played high-res content on it
I watched the debugger logs in xcode and the app's google cast sdk does see my cast device, judging by these logs com.google.cast.CastDevice, ID = ..., instance = (null), name = 'Living Room TV', address = 192.168.32.33:8009> rawID = ...

anubhavpulkit commented 4 years ago

@cpg I have a question related to testing when you play the video in Amhai-iOS app while test( when Chrome cast network is present) cast Does cast symbol appear at the top of video player?

cpg commented 4 years ago

No. That is what I mean by "not appear to do anything" different.

anubhavpulkit commented 4 years ago

No. That is what I mean by "not appear to do anything" different.

Unfortunately, there is no replacement for testing a cast other than testing on a Chromecast.

cpg commented 4 years ago

What?! What does that even mean in English?

If you mean to imply that I do not have a Chromecast-device, when I use the YT app, the icon is there and it works.

As I already stated above.

If you do not mean that, please rephrase the sentence.

anubhavpulkit commented 4 years ago

What?! What does that even mean in English?

If you mean to imply that I do not have a Chromecast-device, when I use the YT app, the icon is there and it works.

As I already stated above.

If you do not mean that, please rephrase the sentence.

I mean 'Do you know any other method to test cast feature without Chromecast-device'. So I can't disturb you every time. Sorry, I think you get in the wrong way. My bad Sorry.

cpg commented 4 years ago

Casting through the media queue is working from #204

anubhavpulkit commented 4 years ago

For testing Google Cast, you can create a virtual Android TV device using Android Studio.

we can test only Android app through this I think.