amahi / ios

Amahi iOS App
https://www.amahi.org/ios
GNU General Public License v3.0
43 stars 65 forks source link

Crashlytics #327

Open anubhavpulkit opened 4 years ago

anubhavpulkit commented 4 years ago

Description

Firebase Crashlytics is a lightweight, realtime crash reporter that helps you track, prioritize, and fix stability issues that erode your app quality. Crashlytics saves you troubleshooting time by intelligently grouping crashes and highlighting the circumstances that lead up to them.

Fixes #296

Type of Change:

How Has This Been Tested?

Tested in the simulator and in firebase console.

Checklist:

anubhavpulkit commented 4 years ago

To build now we need to add googleService-info.plist file. The googleService-info.plist file contains configuration details, such as keys and identifiers, for the services that we have enabled for crashlytics.

cpg commented 4 years ago

I rebased it to be against beta .. please fix the conflict by updating the pods.

anubhavpulkit commented 4 years ago

I rebased it to be against beta .. please fix the conflict by updating the pods.

Done all conflicts are resolved, the branch is now ready to merge.

anubhavpulkit commented 4 years ago

About GoogleService-Info.plist file.

I think we have no privacy issue from GoogleService-Info.plist file because we need only Bundle identifier to download GoogleService-Info.plist file and Bundle identifier is easily available in public. Therefore I think adding GoogleService-Info.plist in the public repo is totally fine and it makes no harm to the privacy issue of our app.

firebase

https://console.firebase.google.com/u/0/project/amahi-3252a/overview

cpg commented 4 years ago

The documentation spells it clearly. Next time please don't forget to read the documentation.

chirag-jn commented 4 years ago

Please remember to remove GoogleService-Info.plist file from the other PR too #298

anubhavpulkit commented 4 years ago

The documentation spells it clearly. Next time please don't forget to read the documentation.

Ok, @cpg I always remember to read the documentation before adding new features. From next time. Thank You