Audio Player Gestures - Githubissues

amahi / ios

Amahi iOS App

https://www.amahi.org/ios

GNU General Public License v3.0

43 stars 65 forks source link

Closed ShresthPratapSingh closed 4 years ago

ShresthPratapSingh commented 4 years ago

This PR adds swipe gestures to navigate between songs. This PR also implements progressively fetching of Metadata for better experience.

Fixes #205 Fixes #313 Fixes #325

Tested on iOS simulators(iOS 11, 12, 13) and on device (iOS 13.6)

[x] My PR follows the style guidelines of this project
[x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

cpg commented 4 years ago

Great improvement. This is what I came across:

[x] When repeat-one-song is in effect, I notice that the list of songs remains, but pressing on any son yields the currently playing song. UX wise, tapping on one song then hearing another is not good. OTOH, repeating the one song is logical. Perhaps tapping on one of the songs on what's next ought to play that and make that the repeat-one-song track! Easy?
[x] When repeat-one-song is in effect, the image swiping effect does not finish. It leaves the artwork half way slid on the screen. Easy to fix?
[x] The artwork aspect ratio is not preserved still.

ShresthPratapSingh commented 4 years ago

@cpg please let me know the device you're using for testing so that I replicate the image aspect ratio issue on that.

cpg commented 4 years ago

It's a year old iphone x. i shared the song with you. please fix the conflicts, validate all is working.

ShresthPratapSingh commented 4 years ago

@cpg I've implemented the suggested changes and resolved conflicts. This PR is ready to merge.