search

amahi / ios

Amahi iOS App
https://www.amahi.org/ios
GNU General Public License v3.0
43 stars 65 forks source link

Full Screen changes #333

Closed ShresthPratapSingh closed 4 years ago

ShresthPratapSingh commented 4 years ago

Description

The previous implementation to resolve login page still appearing in background involves using a static function that overrides presentation behaviour for every view controller even when not required. Also method-swizzling (an obj-c technique) used to achieve this has some cons in itself.

This PR uses swift APIs to do the required changes without changing any default behaviour.

cpg commented 4 years ago

The movie player is not full screen.

ShresthPratapSingh commented 4 years ago

@cpg I've implemented the suggested changes. This PR is ready to merge.