amaiorano / vectrexy

A Vectrex emulator written in modern C++
MIT License
50 stars 9 forks source link

cmake errors #8

Closed ExploitHeaven closed 10 months ago

ExploitHeaven commented 11 months ago

W:\vectrexy\build>cmake .. -- Running vcpkg install Detecting compiler hash for triplet x64-windows... A suitable version of powershell-core was not found (required v7.2.0). Downloading portable powershell-core v7.2.0... Extracting powershell-core... A suitable version of 7zip was not found (required v19.0.0). Downloading portable 7zip v19.0.0... Extracting 7zip... msiexec failed while extracting 'W:\vectrexy\external\vcpkg\downloads\7z1900-x64.msi' with message: 'msiexec' is not recognized as an internal or external command, operable program or batch file.

-- Running vcpkg install - failed CMake Error at external/vcpkg/scripts/buildsystems/vcpkg.cmake:831 (message): vcpkg install failed. See logs for more information: W:\vectrexy\build\vcpkg-manifest-install.log Call Stack (most recent call first): C:/Program Files/CMake/share/cmake-3.28/Modules/CMakeDetermineSystem.cmake:170 (include) CMakeLists.txt:37 (project)

-- Configuring incomplete, errors occurred!

I tried many things like adding vcpkg to environmental path but nothing seems to work :C

amaiorano commented 11 months ago
Extracting 7zip...
msiexec failed while extracting 'W:\vectrexy\external\vcpkg\downloads\7z1900-x64.msi' with message:
'msiexec' is not recognized as an internal or external command,
operable program or batch file.

This isn't a problem with vectrexy, but rather with vcpkg it seems. Although not the same error, here's an example of another kind of error people were hitting when they introduced the msi package for 7zip.

Have you tried updating your vcpkg to latest (git pull, then run the bootstrap script)?

ExploitHeaven commented 11 months ago

Yes I just installed the most recent vcpkg

amaiorano commented 11 months ago

I'll try this on my machine later, but one thing you can check is to open a cmd.exe, and type where msiexec. It should return a path to msiexec.exe, like C:\Windows\System32\msiexec.exe.

Btw, what version of Windows are you on? Is it 64 or 32-bit?

ExploitHeaven commented 11 months ago

I'm on 64bit windows. where command is not recongized on my system due to probably broken environmental path s :C .

amaiorano commented 11 months ago

I'm on 64bit windows. where command is not recongized on my system due to probably broken environmental path s :C .

Ah, that would explain the problem. You'll want to make sure you PATH is in a good state. It should, especially, contain the following: C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem

ExploitHeaven commented 11 months ago

Windows 11 btw. fixed paths, where msiexec returns C:\Windows\System32\msiexec.exe correctly. Tried git pull on vcpkg and says Already up to date. vcpkg is in different folder from the vectrexy directory.

amaiorano commented 11 months ago

Windows 11 btw. fixed paths, where msiexec returns C:\Windows\System32\msiexec.exe correctly. Tried git pull on vcpkg and says Already up to date. vcpkg is in different folder from the vectrexy directory.

So after updating PATH, you opened a brand new shell (cmd.exe), and tried running cmake .. again? You might need to delete the build directory (or just the file CMakeCache.txt in there) and try cmake .. again.

ExploitHeaven commented 11 months ago

Yes, it still shows same error. I think it doesn't matter but I tried both visual studio 2017 and 2022. Nevertheless, Thank you for helping me I'm gonna figure out the issue myself. I have followed your awesome project until day 24 and I followed along coding with you but I thought I will miss the debugging part of your project so that's why

amaiorano commented 11 months ago

Yes, it still shows same error. I think it doesn't matter but I tried both visual studio 2017 and 2022.

If you fixed your PATH, then just try rebooting your machine. This way, all processes will see the new PATH.

Nevertheless, Thank you for helping me I'm gonna figure out the issue myself. I have followed your awesome project until day 24 and I followed along coding with you but I thought I will miss the debugging part of your project so that's why

That's really great! Thanks for following along :)