search

amakaseev / sprite-sheet-packer

Sprite sheet packer
MIT License
319 stars 62 forks source link

Add optimizer setting to project file. #18

Closed TheCodez closed 8 years ago

TheCodez commented 8 years ago

The crash on closing is fixed, but i think it's leaking memory. For now i think leaking is better than crashing.

amakaseev commented 8 years ago

plz return

preferencesDialog->setAttribute(Qt::WA_DeleteOnClose);
aboutDialog->setAttribute(Qt::WA_DeleteOnClose);

is a correct

MainWindow.cpp

614: QObject::connect(publisher, &PublishSpriteSheet::onCompleted, [publishStatusDialog, publisher] () {
613: if (publishStatusDialog) {

always true [a,&b] where a is captured by value and b is captured by reference.

TheCodez commented 8 years ago

This setAttribute(Qt::WA_DeleteOnClose) is still there, its just in the class constructor. Should I change that back? I will change that lambda.