search

amake / flutter.el

Flutter tools for Emacs
GNU General Public License v3.0
123 stars 11 forks source link

Add test at point #9

Closed ericdallo closed 4 years ago

ericdallo commented 4 years ago
ericdallo commented 4 years ago

c/c @amake

amake commented 4 years ago

This is good to go, except for one last thing: I make heavy use of the default key bindings for the ruby-test-mode functions, so adding similar bindings for this would be nice.

If you're not up for that on this PR then I will merge and we can think about that some other time.

ericdallo commented 4 years ago

Sure, what default keybindings do you suggest? I'll use the same of ruby-test-mode, is It ok?

ericdallo commented 4 years ago

@amake should I create a new minor-mode for flutter.el? like here

amake commented 4 years ago

Yes, that's great. And same keybindings as ruby-test-mode is perfect.

ericdallo commented 4 years ago

@amake I added the bindings, but it looks like for me, dart-server already uses the prefix binding C-c C-t for dart-server-find-top-level-decls, do you think we need a different keybinding for flutter-test-mode?

amake commented 4 years ago

Hmm. I don't use dart-server anymore; instead I use lsp-mode. I don't want to start a fight, but I think having the defaults be the same as ruby-test-mode (and be as easy to remember as C-c C-t) is very compelling.

People can always rebind if they need to use both.

So I say it's fine as-is.

amake commented 4 years ago

Thank you!