amake / orgro

An Org Mode file viewer for iOS and Android
https://orgro.org
GNU General Public License v3.0
452 stars 21 forks source link

Wrongly changing Heading level #51

Closed rgshresth closed 2 years ago

rgshresth commented 2 years ago

I have purchsed Orgro on Android. When I import an Org file, one specific level-1 Heading (out of 16 level-1 headings) becomes a Level-3 sub-heading of the preceding Level-1 Heading. The same file imports correctly on Orgzly, showing all the Level-1 Headings. Not clear why this is happening.

amake commented 2 years ago

Probably the parser is not handling it correctly.

Can you provide an org snippet for me to reproduce?

amake commented 2 years ago

(Oh and thank you for your purchase. I appreciate it!)

rgshresth commented 2 years ago

Hello there!

So I figured that the problem was being caused because in the previous level-1 heading, I had mistakenly added a 'blank' level-2 heading at the very end.

Meaning, I had pressed cntr-enter at the last level-2 heading but then got distracted and didn't enter any text for the new level-2 heading.

When folded, this blank level-2 heading was not visible, but for some reason, orglo was then 'demoting' the level-1 heading immediately below this blank level-2 heading.

Once I deleted the asterix (*) of the blank entry and re-imported the org file into orglo, it now shows correctly.

This seems to be a minor bug - you could try reproducing it and correcting it, if possible. As I mentioned on GitHub, Orgzly was importing the file correctly even with the blank level-2 heading.

On an unrelated note, do you plan to add the functionality to open relative links to non-org files (such as PDFs) at some stage?

On Tue, 16 Nov, 2021, 12:40 Aaron Madlon-Kay, @.***> wrote:

Probably the parser is not handling it correctly.

Can you provide an org snippet for me to reproduce?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/amake/orgro/issues/51#issuecomment-969939061, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWQPNOJC4I2UNPNATJDQ4MLUMH7WFANCNFSM5IDQF5MQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

amake commented 2 years ago

Thanks for the details. This sounds like https://github.com/amake/org_parser/issues/5. I am working on a fix.

On an unrelated note, do you plan to add the functionality to open relative links to non-org files (such as PDFs) at some stage?

If I can find a cross-platform way to delegate the opening of such files to the OS, then I would like to add that. But what I don't want to do is add PDF, etc., support to Orgro itself (unless Org Mode has such functionality, in which case it would be within scope to incorporate something similar into Orgro).

amake commented 2 years ago

The headline parsing issue should be fixed in the next version. You can test a pre-release if you like: