amake / orgro

An Org Mode app for iOS and Android
https://orgro.org
GNU General Public License v3.0
478 stars 22 forks source link

Bad performance on large files #52

Open chmol opened 2 years ago

chmol commented 2 years ago

Hi,

My phone is a 8 year old motorola and it takes Ogro ~30 seconds to open a file of 212K around ~ 5000 lines. However opening the same file with Orgzly is instantaneous.

I'm aware I'm on the extreme in this situation and don't expect any resolution but I guess it's worth reporting it.

Thanks,

amake commented 2 years ago

I do feel your pain. I have a 1.8MB file with 29K lines that takes 30s to parse on my Pixel 2.

A major problem is that Android CPUs are quite weak, especially one from 8 years ago. The same 29K line file takes just 8s to parse on my iPhone XS.

As for the comparison with Orgzly, as far as I know Orgzly is doing much less than Orgro is: Orgro supports basically all org syntax, while Orgzly is probably much more focused and can therefore be faster.

However there is a good chance that my org_parser is not as efficient as it could be. I'd like to improve it but I'm not an expert on PEG parsing and I'm not really sure where to start.