search

amake / orgro

An Org Mode app for iOS and Android
https://orgro.org
GNU General Public License v3.0
503 stars 23 forks source link

Respect national settings for date format #99

Closed rrgmitchell closed 2 months ago

rrgmitchell commented 3 months ago

It would be good to see (where configured) European date format in file listings. Example, to me 8/6/2024 is the 8th of June, whereas OrgRo means it to be the 6th of August.

amake commented 3 months ago

I assume you're talking about the date shown under previously opened files on the start screen. On iOS for me this respects the locale that the app is run under: English, Japanese, or Ukranian. The app is not localized for other locales, so it will fall back to one of the above.

rrgmitchell commented 3 months ago

Hi Aaron,

Thanks for your quick response.

You're right that this is about the date next to previously opened files.

I am using OrgRo on an IPhone, with IOS 16.7.8.

My 'Language and Region' in Settings has

*Region: United Kingdom* Date Format: 19/08/2024

See attached screenshot.

I guess the English locale that the app uses must be US English, with US date format. I was hoping that formatting the date according to the region setting might be a relatively simple thing to do, but perhaps not. I am a developer, but not on mobile!

By the way, OrgRo is a superb app, the best for viewing org files on mobile that I have seen.

Best wishes,

Ron

----- Original message ----- From: Aaron Madlon-Kay @.> To: amake/orgro @.> Cc: rrgmitchell @.>, Author @.> Subject: Re: [amake/orgro] Respect national settings for date format (Issue #99) Date: Wednesday, 14 August 2024 16:33

I assume you're talking about the date shown under previously opened files on the start screen. On iOS for me this respects the locale that the app is run under: English, Japanese, or Ukranian. The app is not localized for other locales, so it will fall back to one of the above.

• What OS are you using? What version? • What are your OS language settings? (Unless your OS version is ancient this should be a priority list of locales)

— Reply to this email directly, view it on GitHub https://github.com/amake/orgro/issues/99#issuecomment-2289125622, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGFCPUJ4M2X332K2VW2WLZRN2DDAVCNFSM6AAAAABMQOYKUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBZGEZDKNRSGI. You are receiving this because you authored the thread.Message ID: @.***>

amake commented 3 months ago

Unfortunately screenshots do not come through via email.

It looks like en locale is treated by the Flutter internationalization libraries as en_US. This looks solvable by supporting en_GB as well. The only spelling difference in any of the current Orgro strings appears to be "serialization" → "serialisation", so please do enjoy that 😄

amake commented 3 months ago

This should be fixed in v1.38.0, available for testing soon:

amake commented 3 months ago

v1.38.0 is available for testing.

amake commented 2 months ago

v1.38.0 is released for iOS and Android

rrgmitchell commented 2 months ago

Many thanks for this change. I can now make sense of the dates on my files!

Best,

Ron

On Mon Aug 26, 2024 at 3:54 PM BST, Aaron Madlon-Kay wrote:

v1.38.0 is released for iOS and Android