amakvana / SwitchEmuModDownloader

SwitchEmuModDownloader - A Cross-Platform One-Click Games Mod Downloader for Switch emulators. Formerly YuzuModDownloader.
GNU General Public License v3.0
567 stars 35 forks source link

.NET Unhandled Exception Error #17

Closed rods012 closed 1 year ago

rods012 commented 2 years ago

Whenever pressing "Download Yuzu Game Mods", the program waits for a while until getting an Unhandled Excetion from Microsoft .Net Framework. This happens with either the "Clear Mod Data Location" or "Delete Downloaded Mod Archives" options selected or not.

This is what the error says: Yuzu Mod Downloader Error.txt

I have installed all of the appropriate versions of the prerequisites. However, I had a newer version of the .NET Framework installed already.

It seems that independent of what I do the error continues to appear.

amakvana commented 2 years ago

Thanks for this! Can you tell me a couple of things:

amakvana commented 2 years ago

@rods012 also while you're getting this info for me, try running the following:

  1. Start > Command Prompt
  2. Copy & Paste the commands below into Command Prompt, pressing Enter after typing each one:
rd /s /q "%appdata%\yuzu\7z"
rd /s /q "%appdata%\yuzu\load"
md "%appdata%\yuzu\load"
  1. Rerun YuzuModDownloader and see if the errors persist
rods012 commented 2 years ago

Current Games in my Library:

I tried doing the command prompt things but the error persisted.

amakvana commented 2 years ago

In this folder C:\Users\Rods\AppData\Roaming\yuzu, do you have a 7z folder? If so, can I see the contents of it?

Also, did you also move the HtmlAgilityPack.dll into the same folder as YuzuModDownloader.exe?

rods012 commented 2 years ago

Inside of the 7z folder there is a 7z.zip file

I did also move the HtmlAgilityPack.dll when downloading and copying the files for the downloader. I also just checked it again to make sure it is there.

amakvana commented 2 years ago

Inside of the 7z folder there is a 7z.zip file

Is there anything else excluding the 7z.zip file? If not, can you tell me the size of that zip file.

There may be something blocking the connection to where 7z.zip gets pulled down from

XxCatEggxX commented 1 year ago

I'm going to continue off of what was being given, the 7z.zip is the only file there and is completely empty and is 0 KB

aevans0001 commented 1 year ago

So I have the same issue and I also find that the 7z.zip file is 0kb. I believe there may be a problem with the download location. Is there a way to add that download manually and then it may skip it?

amakvana commented 1 year ago

Thanks for all the feedback! @rods012, @aevans0001, @XxCatEggxX

I've added this specific hotfix to the attached copy of YMD.exe and changed the internals slightly.

  1. YuzuModDownloader now checks to see if 7-Zip is installed locally. If so, it uses the locally installed copy to extract files
  2. I have changed where 7z.zip is pulled from if 7-Zip is not downloaded from my own storage space to GitHub. I think the previous link maybe blocked in certain areas

Let me know if this fixes the issues. If so, I can push this into the main branch YuzuModDownloader.zip

NOTE: This is just the executable so ensure you do not delete the dll's prior. NOTE: Delete the old 0kb 7z.zip prior to running the attached copy of ymd.exe

XxCatEggxX commented 1 year ago

@amakvana I appreciate you working on this problem, I will try my best to work with you to help figure this problem out. It did fully run this time without the error occurring and downloaded the mods, the mods did install properly and are working. I deleted the 7z folder along with clearing out the load folder before doing this, I also launched yuzu before running it to see if there were any updates. If you don't launch yuzu before using the mod downloader you may encounter this. I do believe you've fixed the problem 0 Games Found

amakvana commented 1 year ago

@XxCatEggxX thanks for confirming the fixes work. I will push an update later in the week

aevans0001 commented 1 year ago

Thanks!

amakvana commented 1 year ago

Closed - Fixed in v1.2.0.0 https://github.com/amakvana/YuzuModDownloader/releases/latest