amakvana / SwitchEmuModDownloader

SwitchEmuModDownloader - A Cross-Platform One-Click Games Mod Downloader for Switch emulators. Formerly YuzuModDownloader.
GNU General Public License v3.0
567 stars 35 forks source link

Add option for yuzu directory #2

Closed maltejur closed 3 years ago

maltejur commented 3 years ago

Screenshot 2021-07-27 133408

EL86 commented 3 years ago

Question, when I extract the zip and look in the folder, I can't find the exe file, where is it?

amakvana commented 3 years ago

@maltejur The directories are automatically detected within the ModDownloader.cs class, therefore having a dialog to browse to it is not required

public ModDownloader()
{
UserDirPath = Directory.Exists("user") ?
Path.Combine(Path.GetDirectoryName(Application.ExecutablePath), "user") :
Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData), "yuzu");
}

If there is a "user" folder present in the same directory as yuzu.exe then that will be chosen, otherwise it defaults to the AppData location automatically

amakvana commented 3 years ago

Question, when I extract the zip and look in the folder, I can't find the exe file, where is it?

Ensure your antivirus hasn't tried to remove the .exe from the .zip. I can confirm that both the .exe and .dll are present in the .zip archive

EL86 commented 3 years ago

Question, when I extract the zip and look in the folder, I can't find the exe file, where is it?

Ensure your antivirus hasn't tried to remove the .exe from the .zip. I can confirm that both the .exe and .dll are present in the .zip archive

I'm pretty sure that my antivirus hasn't done anything, here is the folder image after extracting. image

amakvana commented 3 years ago

Question, when I extract the zip and look in the folder, I can't find the exe file, where is it?

Ensure your antivirus hasn't tried to remove the .exe from the .zip. I can confirm that both the .exe and .dll are present in the .zip archive

I'm pretty sure that my antivirus hasn't done anything, here is the folder image after extracting. image

Download it from the URL below: https://github.com/amakvana/YuzuModDownloader/releases/latest

Double-click on YuzuModDownloader.zip, not Source.zip

Also, please create a new Issue with this so I don't hijack the original Pull Request

maltejur commented 3 years ago

@maltejur The directories are automatically detected within the ModDownloader.cs class, therefore having a dialog to browse to it is not required

I haven't removed the automatic detection, that still works. I have just added the option to change the automatically detected directory, for the case that the user has the yuzu folder in another location.

For example I want to use the program on linux with wine, where the standard yuzu directory is located at Z:\home\maltejur\.local\share\yuzu.

amakvana commented 3 years ago

@maltejur The directories are automatically detected within the ModDownloader.cs class, therefore having a dialog to browse to it is not required

I haven't removed the automatic detection, that still works. I have just added the option to change the automatically detected directory, for the case that the user has the yuzu folder in another location.

For example I want to use the program on linux with wine, where the standard yuzu directory is located at Z:\home\maltejur\.local\share\yuzu.

Oh, I see! I didn't realise Wine uses a different path. I'll look to add in some custom folder options soon

maltejur commented 3 years ago

I'll look to add in some custom folder options soon

Is there still something you would change in the pr?

amakvana commented 3 years ago

I'll look to add in some custom folder options soon

Is there still something you would change in the pr?

Possibly, but semantics and maybe having a checkbox option or something. Once it hits the weekend, I'll have more chance to think about it as I'm juggling two jobs at the moment 🤣

maltejur commented 3 years ago

Ah yes sure no pressure :D

And a checkbox shouldn't be necessary since by default the detected path is in the field and the user doesn't have to touch it at all.

maltejur commented 3 years ago

Ahh the damn bot, I'll open another PR